Added a LookupScopeStatement node
#1742
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
added
the
graph-changing
oxisto
force-pushed
the
search-scope-statement
branch
from
be142cd
to
c32c59b
Compare
This PR adds a new node type `LookupScopeStatement`, which can be used to adjust the lookup scope of symbols that are resolved in the current scope. Most prominent examples are Python's `global` and `nonlocal` statements. Support for python will be added in a later PR. This will only add the node and provides the basic functionality in the lookup.
oxisto
force-pushed
the
search-scope-statement
branch
from
a07e0b3
to
7718e61
Compare
|
|
|
||
| // Add it to our scope | ||
| for (symbol in symbols) { | ||
| node.scope?.predefinedLookupScopes[symbol] = node |
There was a problem hiding this comment.
I don't get this. Don't we want do do something with targetScope? Or add the information to the symbol?
What's the purpose of this?
There was a problem hiding this comment.
we are storing the node in predefinedLookupScopes so that it can later be retrieved by lookupSymbol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new node type
LookupScopeStatement, which can be used to adjust the lookup scope of symbols that are resolved in the current scope. Most prominent examples are Python'sglobalandnonlocalstatements. There is also potentially aglobalstatement in PHP, although we do not support that language.Potentially, this could be re-used to for concepts that are similar in other languages as well.
Support for python will be added in a later PR. This will only add the node and provides the basic functionality in the lookup.